Skip to content

fix: change into transformOrigin to correct attribute name#3611

Merged
bfintal merged 1 commit intodevelopfrom
fix/3608-transform-origin-attr
Oct 10, 2025
Merged

fix: change into transformOrigin to correct attribute name#3611
bfintal merged 1 commit intodevelopfrom
fix/3608-transform-origin-attr

Conversation

@Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Oct 7, 2025 •
edited by coderabbitai bot
Loading

fixes #3608

Summary by CodeRabbit

  • New Features

    • None.

  • Refactor

    • Renamed the “Transition Origin” setting to “Transform Origin” in transform controls for clearer terminology. Existing behavior and defaults remain unchanged.

  • Style

    • Updated naming to align with expected transform terminology in the UI.

@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025 •
edited
Loading

Walkthrough

Renamed the attribute key transitionOrigin to transformOrigin in addAttributes within src/block-components/transform/attributes.js. The type and default remain unchanged (type: 'string', default: ''). No other logic or attributes were modified.

Changes

Cohort / File(s) Summary
Transform attributes
src/block-components/transform/attributes.js		 Renamed exported/public attribute key transitionOrigin → transformOrigin in addAttributes; preserved type and default values; no other structural or control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at keys that change,
From transition to transform—simple, strange.
A tiny hop, a saved position,
Now origins keep their true precision.
I stamp my paw: no more forgettin’—
Refresh the page, it stays as written! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title explicitly references the fix of renaming the attribute to “transformOrigin,” which is the primary change in the pull request and directly relates to correcting the attribute name in the code.
Linked Issues Check ✅ Passed Renaming the attribute from transitionOrigin to transformOrigin directly addresses the persistence bug described in issue #3608 by aligning the code with the expected property name, ensuring the Transform Origin setting is saved and reapplied.
Out of Scope Changes Check ✅ Passed The only change in this pull request is the renaming of the attribute key within the transform attributes module, and there are no modifications outside the scope of correcting the attribute name for Transform Origin handling.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/3608-transform-origin-attr
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 578783c and b39231f.

📒 Files selected for processing (1)
  • src/block-components/transform/attributes.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: PHP 7.3 and WP 6.5.5
  • GitHub Check: PHP 7.3 and WP latest
  • GitHub Check: PHP 8.2 and WP 6.6.2
  • GitHub Check: PHP 8.2 and WP latest
  • GitHub Check: PHP 8.2 and WP 6.5.5
  • GitHub Check: PHP 8.2 and WP 6.7.2
🔇 Additional comments (1)
src/block-components/transform/attributes.js (1)

8-11: LGTM! Critical fix for persisting Transform Origin settings.

The attribute name correction from transitionOrigin to transformOrigin directly addresses issue #3608. This mismatch prevented the setting from persisting across saves.

Please verify:

  1. Consistent usage across the codebase:
#!/bin/bash
# Check for any remaining references to the old attribute
rg -n 'transitionOrigin' -g '*.js' -g '*.jsx' -g '*.ts' -g '*.tsx'

# Confirm usage of the new attribute in context
rg -n 'transformOrigin' -g '*.js' -g '*.jsx' -g '*.ts' -g '*.tsx' -C2
  1. Migration strategy for existing content: ensure blocks saved with transitionOrigin are migrated (e.g., add a deprecation/migration in the versioned schema).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

🤖 Pull request artifacts

file commit
pr3611-stackable-3611-merge.zip b39231f

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3611-stackable-3611-merge.zip"}}]}

github-actions bot added a commit that referenced this pull request Oct 7, 2025
@github-actions
Upload pr3611-stackable-3611-merge.zip (b3923)
43a89a0 
Pull request: #3611
Commit: b39231f
@bfintal bfintal merged commit a206c63 into develop Oct 10, 2025
8 of 9 checks passed
@bfintal bfintal deleted the fix/3608-transform-origin-attr branch October 10, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transform origin setting resets to default

2 participants

@Arukuen @bfintal